Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): handle UNAUTHORIZED errors #18751

Merged
merged 3 commits into from Aug 22, 2022
Merged

fix(cli): handle UNAUTHORIZED errors #18751

merged 3 commits into from Aug 22, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 22, 2022 •
edited

Why

The API error didn't match anymore causing unauthorized accounts to fail when loading signed manifests. This was reported by the React Navigation team in Discord.

Test Plan

  • expo.owner: 'foobarthing' in app.json
  • expo start --ios should warn and continue loading the project in Expo Go as expected:
This project belongs to @react-navigation and you have not been granted the appropriate permissions.
Please request access from an admin of @react-navigation or change the "owner" field to an account you belong to.
Learn more: https://docs.expo.dev/versions/latest/config/app/#owner
Falling back to offline mode.

Continuous

  • We had tests in place but they didn't work, now they do.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 22, 2022
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
f25f372 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 22, 2022
@EvanBacon EvanBacon merged commit 5529fec into main Aug 22, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/classic-manifest-unauth-handling branch August 22, 2022 21:23
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
@EvanBacon @expo-bot @Ddv0623
fix(cli): handle UNAUTHORIZED errors (expo#18751)
fbd671b 
* fix(cli): handle UNAUTHORIZED errors

* Update ClassicManifestMiddleware-test.ts

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EvanBacon @expo-bot