Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export config-plugins from expo package and update docs #18855

Merged
merged 12 commits into from
Sep 25, 2022

Conversation

brentvatne
Copy link
Member

Why

jakobo/expo-community-flipper#16

Fixes ENG-6059

Checklist

@linear
Copy link

linear bot commented Aug 26, 2022

ENG-6059 Explain for third party library authors how to add a config plugin dependency to a library

  • peer dependency on expo
  • peerdependenciesmeta to mark as optional

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 26, 2022
Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brentvatne brentvatne requested review from EvanBacon and removed request for Simek and kbrandwijk September 14, 2022 23:16
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 14, 2022
@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions and removed bot: passed checks ExpoBot has nothing to complain about labels Sep 16, 2022
@brentvatne
Copy link
Member Author

The following packages currently use private APIs from @expo/config-plugins, so I didn't change them to use the new format yet:

  • expo-build-properties: @expo/config-plugins/build/utils/generateCode, @expo/config-plugins/build/plugins/android-plugins (for mocking in test), @expo/config-plugins/build/plugins/ios-plugins (for mocking in test)
  • expo-camera: @expo/config-plugins/build/utils/generateCode
  • expo-image-picker: @expo/config-plugins/build/android/Manifest
  • expo-dev-client: @expo/config-plugins/build/android/Manifest

I think we should fix these in a follow-up PR. @EvanBacon - should we be exposing Manifest and generateCode through the public API?

@brentvatne brentvatne merged commit 435bbba into main Sep 25, 2022
@brentvatne brentvatne deleted the @brent/reexport-config-plugins branch September 25, 2022 20:06
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 1740f0a

@KiwiKilian
Copy link
Contributor

@rnmapbox/maps also uses some private APIs which are currently not exported with the new style:

import {
  mergeContents,
  removeGeneratedContents,
} from '@expo/config-plugins/build/utils/generateCode';

Do you already have any followup issue on this topic?

@brentvatne
Copy link
Member Author

@KiwiKilian - you should be able to copy and paste those functions out into the mapbox library, these aren't intended to be public APIs. ideally we want to come up with a better API for interacting with podfile

@SimenB
Copy link
Contributor

SimenB commented Nov 10, 2022

Official plugins also use it. https://github.com/expo/config-plugins/blob/ed020d236b8fa4a810adf90a9773d9a2fba36fd4/packages/react-native-pdf/src/withPdf.ts#L7

Maybe expose it as unstable or something up until a replacement is made?

@Simek Simek mentioned this pull request Nov 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants