[expo-dev-menu][expo-dev-launcher] Disable onboarding popup with URL query param

[douglowder]

Why

The onboarding popup breaks some UI tests (e.g. Detox), so there should be an easy way to disable it without having to rebuild the app.

How

Add code to check for disableOnboarding in the URL and set DevMenuPreferences.isOnboardingFinished=true before the app launches.

Additionally, if testing in Detox, you can pass in a launch param to disable the onboarding popup in iOS (but not in Android) as in this example:

        await device.launchApp({
          newInstance: true,
          launchArgs: {
            EXDevMenuIsOnboardingFinished: true,
          },
        });

Test Plan

Tested by passing in a URL like http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&disableOnboarding=1 in the dev launcher.

Checklist

• Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
• Conforms with the Documentation Writing Style Guide
• This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

[linear]

ENG-5957 Make a user facing API to disable the intro pop up

as this gets in the way of testing, and the current mechanism was built for Snack and is not user friendly

Document as well

[ajsmth]

Looks good! Personally I think it makes more sense to have a separate flag for disabled rather than turning off isOnboardingFinished in this case, but I don't think it makes much of a difference.

Is there some instructions / plans for documentation around this? I'm not 100% familiar with detox configurations, it might be nice to add some info around this

[ajsmth]

Suggested change

	This is now public because expo-dev-launcher needs access
	This is public because expo-dev-launcher needs access

[douglowder]

@ajsmth I am actively working on the docs for this -- had a discussion with @brentvatne yesterday and we are attempting to figure out exactly where this should be in the docs ("Development Builds" and/or "EAS E2E tests").

I'll go ahead and land this and create a separate PR for the doc changes.

[pradeipp]

Hi @douglowder I saw your description and was wondering - will this change not work on android?

[douglowder]

@pradeipp this change works correctly on Android. The issue with Android is just with Detox testing, and is still under investigation.

[pradeipp]

great, thank you @douglowder is there an issue for it that I can follow?

[douglowder]

expo/eas-tests-example#4