[expo-dev-menu] Make internal runtime undebuggable #19269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
changed the title
Kudo
reviewed
Sep 27, 2022
Kudo
approved these changes
Sep 28, 2022
lukmccall
force-pushed
the
@lukmccall/client/make-internal-runtimes-undebuggable
branch
from
98b7a9c
to
b821b0a
Compare
lukmccall
deleted the
@lukmccall/client/make-internal-runtimes-undebuggable
branch
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Takes advantage of facebook/react-native#34489.
It'll improve our integration with Hermes inspector - users don't have to reload their app anymore to see correct sources.
How
Set
enable debuggeron internal runtimes.Test Plan
I couldn't test it properly because our basic template crashes with RN
0.70.