[modules][Android] Fix JSCRuntime destroyed with a dangling API object
#19487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
approved these changes
Oct 10, 2022
packages/expo-modules-core/android/src/main/cpp/ExpoModulesHostObject.h
Outdated
Show resolved
Hide resolved
packages/expo-modules-core/android/src/main/cpp/JavaScriptModuleObject.h
Outdated
Show resolved
Hide resolved
tsapeta
approved these changes
Oct 10, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Kudo Chien <kudo@expo.dev>
expo-bot
added
bot: passed checks
|
thanks for the fix! |
Kudo
pushed a commit
that referenced
this pull request
Oct 13, 2022
…ct` (#19487) Closes #19221. In the current memory modal, all of our JSI references are cleared when GC runs through java unused objects. It turns out that is not the best flow, because JSC has an assertion that checks if all references were cleared. So we have to remove dangling references before the JSC runtime fully deallocates. - bare-expo with JSC and Heremes ✅ (cherry picked from commit 33ae33e)
|
@gasolin the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #19221.
How
In the current memory modal, all of our JSI references are cleared when GC runs through java unused objects. It turns out that is not the best flow, because JSC has an assertion that checks if all references were cleared. So we have to remove dangling references before the JSC runtime fully deallocates.
Test Plan