Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md react-native-svg to 13.4.0 #19531

Merged
merged 2 commits into from Oct 13, 2022
Merged

Conversation

pweisensee
Copy link
Contributor

Why

CHANGELOG.md has incorrect version of dependency react-native-svg from recent PR #19434

How

Did not build or test (N/A)

Test Plan

Did not build or test (N/A)

Checklist

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 12, 2022
@pweisensee
Copy link
Contributor Author

@lukmccall or @tsapeta perhaps you can advise?

Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

CHANGELOG.md Outdated Show resolved Hide resolved
@lukmccall lukmccall merged commit db3ea19 into expo:main Oct 13, 2022
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to appropriate package-specific changelogs.


Generated by ExpoBot 🤖 against c6065bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants