Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @react-native-masked-view/masked-view to 0.2.8 #19645

Merged
merged 2 commits into from Oct 21, 2022

Conversation

gabrieldonadel
Copy link
Member

Why

@react-native-masked-view/masked-view has historically faced an issue on Android where MaskedView flickers showing only the underlying color when navigating on Android devices but this has been fixed on version 0.2.8. This PR upgrades @react-native-masked-view/masked-view to version 0.2.8 in order to mitigate this problem.

Closes #19644

How

et update-module -m @react-native-masked-view/masked-view --commit "v0.2.8"

Test Plan

Manually tested on Android and iOS

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 20, 2022
@gabrieldonadel
Copy link
Member Author

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries
Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against 16bc955

Package @react-native-masked-view/masked-view doesn't have its own changelog file.

@brentvatne
Copy link
Member

@gabrieldonadel - it's best to update the root changelog in these cases, you can ignore the bot in this case.

example: 5d2a4fa#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR10

@gabrieldonadel
Copy link
Member Author

@gabrieldonadel - it's best to update the root changelog in these cases, you can ignore the bot in this case.

example: 5d2a4fa#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR10

Ohh sure, updated

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against d5d1d4e

@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 21, 2022
@gabrieldonadel
Copy link
Member Author

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file
Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:

Generated by ExpoBot 🤖 against d5d1d4e

@brentvatne I guess the bot is a little off

@brentvatne brentvatne merged commit d4213a7 into expo:main Oct 21, 2022
@gabrieldonadel gabrieldonadel deleted the upgrade-maskedview-0.28 branch October 21, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaskedView flickers while navigating on Android
3 participants