Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device] Fix deviceName exception on android sdk > 31 #19666

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Oct 24, 2022

Why

fix #18738

How

<bluetooth_name> is only readable to apps with targetSdkVersion lower than or equal to: 31

for android sdk > 31, we get the device name from Settings.Global(..., Settings.Global.DEVICE_NAME). this is from: https://stackoverflow.com/a/66651458

Test Plan

bare-expo + targetSdkVersion 33 + android emulator 33 + NCL device

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 24, 2022
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 24, 2022
@Kudo Kudo marked this pull request as ready for review October 24, 2022 10:12
@Kudo Kudo requested review from ide and tsapeta as code owners October 24, 2022 10:12
@Kudo Kudo requested review from lukmccall and removed request for ide October 24, 2022 10:13
@therajumandapati
Copy link

@Kudo any idea of when this package update will be released?

@tsapeta
Copy link
Member

tsapeta commented Nov 1, 2022

@therajumandapati It's been released in expo-device@5.0.0 as part of the SDK 47 (still beta for a week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Expo-46 || expo-device] Device.deviceName constant crashes Android 13
5 participants