Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo] Fix missing disable-missing-native-module-errors.js on npm #19815

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Nov 2, 2022

Why

the disable-missing-native-module-errors.js is missing in the expo package on npm.
this pr will fix the problem mentioned in #19811 (comment)

How

should include disable-missing-native-module-errors.js in publishing files

Test Plan

n/a

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 2, 2022
@Kudo Kudo marked this pull request as ready for review November 2, 2022 16:11
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 2, 2022
@brentvatne brentvatne merged commit c96ebba into main Nov 2, 2022
@brentvatne brentvatne deleted the @kudo/fix-19729 branch November 2, 2022 20:30
@mariomurrent-softwaresolutions
Copy link
Contributor

In "expo": "^47.0.2" this file is missing again

@tsapeta
Copy link
Member

tsapeta commented Nov 8, 2022

@mariomurrent-softwaresolutions
We backed off from that, see #19848 for more details

@mariomurrent-softwaresolutions
Copy link
Contributor

Thx for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants