[iOS][expo-sms] migrate expo-sms to new modules api #19996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
fobos531
reviewed
Nov 11, 2022
tsapeta
requested changes
Nov 11, 2022
|
I'll get started on these soon 👍 |
tsapeta
reviewed
Nov 11, 2022
tsapeta
reviewed
Nov 13, 2022
tsapeta
reviewed
Nov 28, 2022
expo-bot
reviewed
Nov 28, 2022
expo-bot
added
bot: suggestions
alanjhughes
force-pushed
the
@alanhughes/ios/sweet-expo-sms
branch
from
6fd49ab
to
8e6bc3f
Compare
tsapeta
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Continue migration of expo modules to the new API
How
Followed the usual steps involved in migrating a module
Test Plan
All original tests pass as before with a minor modification. Changed Constants.isDevice() to Device.isDevice(). Also, one incidence where all tests failed and then passed after that. Maybe @tsapeta will be able to see an issue somewhere?