[android][expo-sharing] migrate to new modules API

packages/expo-sharing/CHANGELOG.md

@@ -6,6 +6,8 @@
 
 ### 🎉 New features
 
+- Migrated Android implementation to Expo Modules API. ([#20112](https://github.com/expo/expo/pull/20112) by [@alanhughes](https://github.com/alanjhughes))
+
 ### 🐛 Bug fixes
 
 ### 💡 Others

packages/expo-sharing/android/src/main/java/expo/modules/sharing/SharingExceptions.kt

@@ -0,0 +1,15 @@
+package expo.modules.sharing
+
+import expo.modules.kotlin.exception.CodedException
+
+internal class MissingCurrentActivityException :
+  CodedException("Activity which was provided during module initialization is no longer available")
+
+internal class SharingInProgressException :
+  CodedException("Another share request is being processed now.")
+
+internal class SharingFailedException(message: String, e: Exception) :
+  CodedException(message, e.cause)
+
+internal class SharingInvalidArgsException(message: String?, e: Exception) :
+  CodedException(message, e.cause)

packages/expo-sharing/android/src/main/java/expo/modules/sharing/SharingModule.kt

@@ -1,81 +1,69 @@
 package expo.modules.sharing
 
-import android.app.Activity
 import android.content.Context
 import android.content.Intent
 import android.content.pm.PackageManager
 import android.net.Uri
 import androidx.core.content.FileProvider
-import expo.modules.core.ExportedModule
-import expo.modules.core.ModuleRegistry
-import expo.modules.core.ModuleRegistryDelegate
-import expo.modules.core.Promise
-import expo.modules.core.arguments.ReadableArguments
 import expo.modules.core.errors.InvalidArgumentException
-import expo.modules.core.interfaces.ActivityEventListener
-import expo.modules.core.interfaces.ActivityProvider
-import expo.modules.core.interfaces.ExpoMethod
-import expo.modules.core.interfaces.services.UIManager
-import expo.modules.interfaces.filesystem.FilePermissionModuleInterface
 import expo.modules.interfaces.filesystem.Permission
+import expo.modules.kotlin.Promise
+import expo.modules.kotlin.exception.Exceptions
+import expo.modules.kotlin.modules.Module
+import expo.modules.kotlin.modules.ModuleDefinition
 import java.io.File
 import java.net.URLConnection
 
-class SharingModule(
-  context: Context,
-  private val moduleRegistryDelegate: ModuleRegistryDelegate = ModuleRegistryDelegate()
-) : ExportedModule(context), ActivityEventListener {
+class SharingModule : Module() {
+  private val context: Context
+    get() = appContext.reactContext ?: throw Exceptions.ReactContextLost()
+  private val currentActivity
+    get() = appContext.currentActivity ?: throw MissingCurrentActivityException()
   private var pendingPromise: Promise? = null
-  private val uiManager: UIManager by moduleRegistry()
-  override fun getName() = "ExpoSharing"
 
-  private inline fun <reified T> moduleRegistry() =
-    moduleRegistryDelegate.getFromModuleRegistry<T>()
+  override fun definition() = ModuleDefinition {
+    Name("ExpoSharing")
 
-  override fun onCreate(moduleRegistry: ModuleRegistry) {
-    moduleRegistryDelegate.onCreate(moduleRegistry)
-    uiManager.registerActivityEventListener(this)
-  }
-
-  override fun onDestroy() {
-    uiManager.unregisterActivityEventListener(this)
-  }
-
-  @ExpoMethod
-  fun shareAsync(url: String?, params: ReadableArguments, promise: Promise) {
-    if (pendingPromise != null) {
-      promise.reject("ERR_SHARING_MUL", "Another share request is being processed now.")
-      return
+    AsyncFunction("shareAsync") { url: String?, params: SharingOptions, promise: Promise ->
+      if (pendingPromise != null) {
+        throw SharingInProgressException()
+      }
+      try {
+        val fileToShare = getLocalFileFoUrl(url)
+        val contentUri = FileProvider.getUriForFile(
+          context,
+          context.applicationInfo.packageName + ".SharingFileProvider",
+          fileToShare
+        )
+        val mimeType = params.mimeType
+          ?: URLConnection.guessContentTypeFromName(fileToShare.name)
+          ?: "*/*"
+        val intent = Intent.createChooser(
+          createSharingIntent(contentUri, mimeType),
+          params.dialogTitle
+        )
+        val resInfoList = context.packageManager.queryIntentActivities(
+          intent,
+          PackageManager.MATCH_DEFAULT_ONLY
+        )
+        resInfoList.forEach {
+          val packageName = it.activityInfo.packageName
+          context.grantUriPermission(packageName, contentUri, Intent.FLAG_GRANT_READ_URI_PERMISSION)
+        }
+        pendingPromise = promise
+        currentActivity.startActivity(intent)
+      } catch (e: InvalidArgumentException) {
+        throw SharingInvalidArgsException(e.message, e)
+      } catch (e: Exception) {
+        throw SharingFailedException("Failed to share the file: ${e.message}", e)
+      }
     }
-    try {
-      val fileToShare = getLocalFileFoUrl(url)
-      val contentUri = FileProvider.getUriForFile(
-        context,
-        context.applicationInfo.packageName + ".SharingFileProvider",
-        fileToShare
-      )
-      val mimeType = params.getString(MIME_TYPE_OPTIONS_KEY)
-        ?: URLConnection.guessContentTypeFromName(fileToShare.name)
-        ?: "*/*"
-      val intent = Intent.createChooser(
-        createSharingIntent(contentUri, mimeType),
-        params.getString(DIALOG_TITLE_OPTIONS_KEY)
-      )
-      val resInfoList = context.packageManager.queryIntentActivities(
-        intent,
-        PackageManager.MATCH_DEFAULT_ONLY
-      )
-      resInfoList.forEach {
-        val packageName = it.activityInfo.packageName
-        context.grantUriPermission(packageName, contentUri, Intent.FLAG_GRANT_READ_URI_PERMISSION)
+
+    OnActivityResult { _, (requestCode) ->
+      if (requestCode == REQUEST_CODE && pendingPromise != null) {
+        pendingPromise?.resolve(null)
+        pendingPromise = null
       }
-      val activityProvider: ActivityProvider by moduleRegistry()
-      activityProvider.currentActivity.startActivityForResult(intent, REQUEST_CODE)
-      pendingPromise = promise
-    } catch (e: InvalidArgumentException) {
-      promise.reject("ERR_SHARING_URL", e.message, e)
-    } catch (e: Exception) {
-      promise.reject("ERR_SHARING", "Failed to share the file: " + e.message, e)
     }
   }
 
@@ -97,8 +85,9 @@ class SharingModule(
   }
 
   private fun isAllowedToRead(url: String?): Boolean {
-    val permissionModuleInterface: FilePermissionModuleInterface by moduleRegistry()
-    return permissionModuleInterface.getPathPermissions(context, url).contains(Permission.READ)
+    val permissions = appContext.filePermission
+    return permissions?.getPathPermissions(context, url)?.contains(Permission.READ)
+      ?: false
   }
 
   private fun createSharingIntent(uri: Uri, mimeType: String?) =
@@ -108,18 +97,7 @@ class SharingModule(
       addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION)
     }
 
-  override fun onActivityResult(activity: Activity, requestCode: Int, resultCode: Int, data: Intent?) {
-    if (requestCode == REQUEST_CODE && pendingPromise != null) {
-      pendingPromise?.resolve(null)
-      pendingPromise = null
-    }
-  }
-
-  override fun onNewIntent(intent: Intent) = Unit
-
   companion object {
     private const val REQUEST_CODE = 8524
-    private const val MIME_TYPE_OPTIONS_KEY = "mimeType"
-    private const val DIALOG_TITLE_OPTIONS_KEY = "dialogTitle"
   }
 }

packages/expo-sharing/android/src/main/java/expo/modules/sharing/SharingOptions.kt

@@ -0,0 +1,10 @@
+package expo.modules.sharing
+
+import expo.modules.kotlin.records.Field
+import expo.modules.kotlin.records.Record
+
+data class SharingOptions(
+  @Field val mimeType: String?,
+  @Field val UTI: String?,
+  @Field val dialogTitle: String?
+) : Record

packages/expo-sharing/expo-module.config.json

@@ -0,0 +1,7 @@
+{
+  "name": "expo-sharing",
+  "platforms": ["ios", "android"],
+  "android": {
+    "modules": ["expo.modules.sharing.SharingModule"]
+  }
+}

packages/expo-sharing/src/ExpoSharing.ts

@@ -1,3 +1,2 @@
-import { NativeModulesProxy } from 'expo-modules-core';
-
-export default NativeModulesProxy.ExpoSharing;
+import { requireNativeModule } from 'expo-modules-core';
+export default requireNativeModule('ExpoSharing');