[modules] Fix incompatible issue for react-native 0.71

[Kudo]

Why

sdk 48 may come next year and react-native 0.71 may be released this year. it's good to have react-native 0.71 support for our modules. if users want to upgrade 0.71, they could change their project to be a bare project for the early preview.

How

• [core][av][gl] because 0.71 doesn't serve android aar along with npm package, the aar extraction from node_modules/react-native/android/**/*.aar will break on 0.71. 0.71 also ships modules with prefab support. it's good to rewrite the gradle/cmake files to link with prefab modules. that would reduce much complexity. however, to be backward compatible with 0.70, i moved most logic to ExpoModulesCorePlugin.applyLegacyReactNativeLibsExtractionPlugin and legacy/CMakeLists.txt. so that we could be backward compatible and easily remove the isolated code after we drop sdk 47 support.
• [dev-launcher] add 0.71 sources because new parameter to DevSupportManagerBase
• [core][dev-menu] fix ios build errors for jsc because 0.71 moved the header to <React-jsc/JSCRuntime.h>
• [core][autolinking] integrate the RCTAppDelegate with our EXAppDelegateWrapper. that would simply the install-expo-modules migration where we only need the change RCTAppDelegate -> EXAppDelegateWrapper in AppDelegate.h. however, integrate RCTAppDelegate comes with some issues from expo-modules-core. this commit changes many code and i'll try to explain here:
  • RCTAppDelegate is in React-RCTAppDelegate pod, which does not define module. we define module for it in our patch system in autolinking.
  • defines RCT_NEW_ARCH_ENABLED as RCTAppDelegate
  • in new architecture mode, RCTAppDelegate comes with more cxx dependencies for fabric. that's why we should add more header search paths and also move to EXAppDelegateWrapper.mm.

Test Plan

• ci passed
• bare-expo build and launch
• bare-expo nightlies build and launch
• fabric-tester build and launch
• fabric-tester nighties build and launch (should apply the patch to fabric-tester)
• rn 0.71-rc4 project build and launch (could apply the patches for testing)
• rn 0.71-rc4 project (new architecture) build and launch (this pr for react-native is required)
• rn 0.71-rc4 project (use_frameworks!) build and launch

Checklist

• Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
• Conforms with the Documentation Writing Style Guide
• This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

[tsapeta]

Looks good to me so far 😉

[tomekzaw]

You can use folly-flags.cmake from react-native node_modules.

[Kudo]

tried to migrate this stuff but it bump the minimum cmake version to 3.13. i don't want to do much new changes for expo sdk 47 patch releases this time. so i'll add an internal task for me to migrate this for sdk 48.
thanks @tomekzaw for this awesome comment.

[tomekzaw]

CallInvoker.h and other headers are available in ReactAndroid::runtimeexecutor prefab.

[Kudo]

thanks @tomekzaw for the kind comment. i just don't want to introduce new linked libs to libexpo-av.so, as expo-av currently doesn't rely on runtimexecutor. although we can get the prefab include path through get_target_property, e.g.

get_target_property(INCLUDE_runtimexecutor
        ReactAndroid::runtimeexecutor
        INTERFACE_INCLUDE_DIRECTORIES)
target_include_directories(
        ${PACKAGE_NAME}
        PRIVATE
        ${INCLUDE_runtimexecutor}
        # ...
)

since we only use the single header, it doesn't hurt to reference the header directly from react-native folder.

[tomekzaw]

Thanks @Kudo for the explanation! I really like the idea of get_target_property, gonna try it in Reanimated! 😄