Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@expo/cli] Avoid dependency on uuid #20479

Merged
merged 3 commits into from Dec 17, 2022
Merged

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Dec 14, 2022

Why

Older versions of uuid is deprecated. This will start using a secure random source, and will produce one less deprecation warning when installing!

uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

How

The @expo/cli package only used the UUID v4 function from a Node.js context, and Node.js already have a randomUUID function built in.

Test Plan

I'm not sure, since this is used in the tests I'm hoping the CI will cover it? 馃槄

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Dec 14, 2022
@LinusU
Copy link
Contributor Author

LinusU commented Dec 15, 2022

Test failure seems unrelated 馃

stderr > Expected: "babel.config.js"
stderr > Received: "/babel.config.js"

@EvanBacon EvanBacon merged commit b1f6697 into expo:main Dec 17, 2022
@LinusU LinusU deleted the expo-cli-uuid branch December 19, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants