Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Initializing Events component with an array of event names #20590

Merged
merged 2 commits into from Dec 23, 2022

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Dec 23, 2022

Why

Addresses the need described in #20488 to allow initializing Events component with an array of event names.

How

Added alternative versions of Events in Swift and also in Kotlin (even though it's possible to pass arrays to a function with variadic arguments using *, but there is no cost to add that too).

Test Plan

Verified that it works in both Module and View definitions.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Dec 23, 2022
@tsapeta tsapeta marked this pull request as ready for review December 23, 2022 12:15
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@tsapeta tsapeta merged commit 69bd198 into main Dec 23, 2022
@tsapeta tsapeta deleted the @tsapeta/modules/events-definition-with-array branch December 23, 2022 12:54
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants