Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo-web-browser): add missing peer dependency on url #20708

Merged
merged 2 commits into from Jan 5, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

  • Webpack automatically mocks this on web, but Metro web does not. I built the mocking system in Metro only to realize that simply installing url would fix the issue.

How

Test Plan

  • Use expo-web-browser in an Expo Router app on web. It will fail. yarn add url then it will work.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 4, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon merged commit 9242ace into main Jan 5, 2023
@EvanBacon EvanBacon deleted the @evanbacon/expo-web-browser/fix-url branch January 5, 2023 12:25
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants