Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): improve UNVERSIONED (internal-only) support #20754

Merged
merged 4 commits into from Jan 9, 2023
Merged

feat(cli): improve UNVERSIONED (internal-only) support #20754

merged 4 commits into from Jan 9, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

Fail a little bit more expectedly when using Expo CLI for UNVERSIONED projects.

Test Plan

  • unit tests
  • tested against apps/test-suite

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 9, 2023
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
bb24670 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 9, 2023
@EvanBacon EvanBacon merged commit 6a116c5 into main Jan 9, 2023
@EvanBacon EvanBacon deleted the @evanbacon/cli/add-unversioned-expo-go-support branch January 9, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EvanBacon @expo-bot