[file-system] Fix UploadProgressData field name typo #20804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-6559 FileSystem UploadProgressData field name typo
Also needs to be changed on native side, eg: expo/packages/expo-file-system/ios/EXFileSystem/EXFileSystem.m Lines 616 to 617 in 168ee43 |
expo-bot
added
bot: passed checks
gabrieldonadel
requested review from
brentvatne,
Kudo,
ide and
tsapeta
as code owners
3 tasks
tsapeta
approved these changes
Jan 12, 2023
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| ### 🛠 Breaking changes | |||
|
|
|||
| - Rename `UploadProgressData` `totalByteSent` field to `totalBytesSent`. ([#20804](https://github.com/expo/expo/pull/20804) by [@gabrieldonadel](https://github.com/gabrieldonadel)) | |||
There was a problem hiding this comment.
Let's move that to Others category. It's not a breaking change as long as it's backwards compatible 😉
There was a problem hiding this comment.
Opss my bad, updated
gabrieldonadel
deleted the
@gabrieldonadel/fix-upload-progress-data-field-name-typo
branch
gabrieldonadel
added a commit
that referenced
this pull request
Jan 13, 2023
<!-- disable:changelog-checks --> # Why Follow-up PR for #20804 Closes ENG-6559 # How `et generate-docs-api-data --packageName expo-file-system` # Test Plan Changes have been tested by running docs locally.  # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
byCedric
pushed a commit
that referenced
this pull request
Jan 17, 2023
# Why `UploadProgressData` `totalByteSent` key should be `totalBytesSent` to be consistent with other FIleSystem properties like `totalBytesExpectedToSend`, `totalBytesWritten` and `totalBytesExpectedToWrite`. Closes ENG-6559 Follow up PR updating docs -> #20810 # How This updates all native references of `totalByteSent` to `totalBytesSent` and adds a getter `totalByteSent` property to `UploadProgressData` events so users get a deprecation warning when accessing `totalByteSent` # Test Plan Added a new `Download & Upload file` button to NCL so we can properly test this https://user-images.githubusercontent.com/11707729/212067976-a4bdd509-8937-4f27-9516-cee35ed94dca.mov # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
byCedric
pushed a commit
that referenced
this pull request
Jan 17, 2023
<!-- disable:changelog-checks --> # Why Follow-up PR for #20804 Closes ENG-6559 # How `et generate-docs-api-data --packageName expo-file-system` # Test Plan Changes have been tested by running docs locally.  # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
UploadProgressDatatotalByteSentkey should betotalBytesSentto be consistent with other FIleSystem properties liketotalBytesExpectedToSend,totalBytesWrittenandtotalBytesExpectedToWrite.Closes ENG-6559
Follow up PR updating docs -> #20810
How
This updates all native references of
totalByteSenttototalBytesSentand adds a gettertotalByteSentproperty toUploadProgressDataevents so users get a deprecation warning when accessingtotalByteSentTest Plan
Added a new
Download & Upload filebutton to NCL so we can properly test thisScreen.Recording.2023-01-12.at.09.35.22.mov
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).