feature(cli): add experimental metro config telemetry #20885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
approved these changes
Jan 25, 2023
byCedric
force-pushed
the
@bycedric/cli/telemetry-metro-traits
branch
from
455ec05
to
120465a
Compare
|
@EvanBacon this PR has changed a bit since you last reviewed, can discuss the latest changes later 😄 |
expo-bot
added
bot: passed checks
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
byCedric
force-pushed
the
@bycedric/cli/telemetry-metro-traits
branch
from
d931b21
to
9733b6a
Compare
|
can we land this to get it in sdk 48? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to have visibility on what experimental features are being used, in order to prioritize supporting or finishing these features.
How
Added a telemetry event when instantiating Metro, for both
npx expo startandnpx expo export.Test Plan
See added test, if a property isn't available, it doesn't matter.
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).