Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][ios] Upgrade react-native-safe-area-context to 4.5.0 #20899

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Jan 20, 2023

Why

Closes ENG-7321

How

  • et update-module -m react-native-safe-area-context -c 'v4.5.0'
  • et pods -f
  • yarn

Test Plan

  • test using bare-expo Android + NCL safe area context (Expo go is currently broken)
  • test using bare-expo iOS + NCL safe area context
  • test unversioned expo go ios + NCL safe area context
  • test unversioned expo go android + NCL safe area context

Checklist

@linear
Copy link

linear bot commented Jan 20, 2023

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 20, 2023
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/update-react-native-safe-area-context-4.5.0 branch from 7fd539e to 19a5ac7 Compare January 20, 2023 17:28
@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Jan 20, 2023
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/update-react-native-safe-area-context-4.5.0 branch from d4f469d to bebfde8 Compare January 20, 2023 19:40
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against bebfde8

@gabrieldonadel gabrieldonadel marked this pull request as ready for review January 20, 2023 20:26
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this was a minor bump but nothing has changed except formatting 😂

@gabrieldonadel gabrieldonadel merged commit fdbd41f into main Jan 23, 2023
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/update-react-native-safe-area-context-4.5.0 branch January 23, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants