Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use position fixed to float fast refresh indicator to the bottom on web #20966

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

Ensure fast refresh shows on screens where the height goes beyond the vertical height of the viewport.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 26, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 27, 2023
@EvanBacon EvanBacon merged commit 148cac5 into main Jan 27, 2023
@EvanBacon EvanBacon deleted the @evanbacon/expo/web-fast-refresh branch January 27, 2023 15:49
jakobo added a commit to jakobo/expo that referenced this pull request Jan 30, 2023
…flipper

* upstream/main: (79 commits)
  [ncl][image] Add examples for Live Text interactions (expo#20988)
  fix(dev-server): add new Android hermes flag detection (expo#20997)
  Remove old expo-cli from workflows and test apps (expo#20998)
  [crypto][docs] Add `digest` method to expo-crypto. (expo#20886)
  [docs] Search: fix text selection color in input (expo#20993)
  [docs] Add note about SDK 45 & update verbiage in Customizing Metro (expo#20989)
  [bare-expo] let android-emulator-runner cleanup the emulator (expo#20994)
  [ncl] fix reanimated setImmediate issue (expo#20992)
  Publish expo-image
  [image][ios] Fix a crash on iOS below 16.0 (expo#20987)
  [android][ios] Upgrade react-native-reanimated to 2.14.4 (expo#20990)
  Update lockfiles 😿 [skip ci]
  Upgrade `@react-native-community/datetimepicker@6.5.2` ➡️ `@react-native-community/datetimepicker@6.7.3` (expo#20926)
  [home] remove InfiniteScrollView and use FlatList-native infinite scroll props (expo#20914)
  [docs] Config Plugins: update code blocks, align with writing styleguide (expo#20974)
  [expo-updates] More E2E setup script changes (expo#20982)
  [docs] APISection: allow interfaces as component props (expo#20968)
  Upgrade `react-native-shared-element@0.8.7` ➡️ `react-native-shared-element@0.8.8` (expo#20929)
  [build-properties][docs] update JSDoc comments, update doc page (expo#20972)
  Use position `fixed` to float fast refresh indicator to the bottom on web (expo#20966)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants