Update react-native-screens to 3.20.0 #21186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
expo-bot
added
bot: needs changes
tsapeta
requested review from
ide,
brentvatne,
byCedric and
EvanBacon
as code owners
|
@alantoa gave it a quick test and it works! Thanks for addressing! |
brentvatne
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It solves software-mansion/react-native-screens#1686 issue for Expo Go and SDK 48
How
et uvm -m react-native-screens -c 3.20.0and made sure locks are updatedTest Plan
Seems to work in Expo Go, but I'm waiting for Hirbod's confirmation if it solves the issue for him