Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metro-config): refactor metro-config for versioned CLI #21330

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

  • Drop the "testing" platform. It's unclear what this is used for and it's seemingly undocumented.
  • Drop the unused "native" platform.
  • Export MetroConfig for use in metro.config.js files.
  • Import metro dependencies from expo/expo when testing rather than from the project. This will make production usage simpler.
  • Assert when expo-asset is not installed. This is an artifact from bare workflow.

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing links in changelog entries


I've added some suggestions below, you can just apply and commit them 😉


Generated by ExpoBot 🤖 against 5e7069b

packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 21, 2023
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing links in changelog entries


I've added some suggestions below, you can just apply and commit them 😉


Generated by ExpoBot 🤖 against c9ac1a3

packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@expo/metro-config/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon merged commit b09eae1 into main Feb 24, 2023
@EvanBacon EvanBacon deleted the @evanbacon/metro-config/refactor branch February 24, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants