feat(cli)!: use Expo CLI to bundle production apps #21396

EvanBacon · 2023-02-25T01:24:49Z

Why

Most of our new Metro bundler features won't work unless we use Expo CLI for every bundler operation (ex: aliases). Right now this is the case when building for production on both platforms or building for development on iOS.

Using npx expo start when building from Xcode will be added in another PR.

How

This PR introduces a new "export:embed" command which is hidden from the --help prompt. npx expo export:embed accepts the same arguments as npx react-native bundle and passes them to the same internal function, but it ensures we use the correct variation of Metro before doing such.

This change (and start PR) will add more steps for migrating to "Expo CLI" but it will also remove the need for us to generate the metro.config.js file in the project on npx expo prebuild since we can now reliably default to @expo/metro-config.

The change should only apply to Metro bundler features (all application code could be affected), but it won't obstruct Expo Modules Core or using Expo CLI.

Test Plan

All of our existing E2E tests should use the new command, if they contain features like aliases then they'll work.
Copied the changes from @expo/cli into a new project's node_modules, added template changes:
- Built for production from Android Studio and Xcode.

Checklist

Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
Conforms with the Documentation Writing Style Guide
This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

expo-bot · 2023-02-25T01:25:36Z

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

packages/@expo/cli/CHANGELOG.md

⚠️ Suggestion: Missing links in changelog entries

I've added some suggestions below, you can just apply and commit them 😉

Generated by ExpoBot 🤖 against 847d575

packages/expo/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

expo-bot · 2023-03-01T18:12:16Z

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing links in changelog entries

I've added some suggestions below, you can just apply and commit them 😉

Generated by ExpoBot 🤖 against f1f6e11

packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

Kudo

appreciated if you could also update fabric-test's project.pbxproj.

apps/bare-expo/ios/BareExpo.xcodeproj/project.pbxproj

docs/pages/versions/unversioned/config/metro.mdx

packages/@expo/cli/bin/cli.ts

packages/@expo/cli/src/export/embed/index.ts

templates/expo-template-bare-minimum/ios/HelloWorld.xcodeproj/project.pbxproj

Kudo · 2023-03-02T03:12:36Z

since in #21397 you've introduced expo/scripts/*, maybe we could later move these additionals of project.pbxproj into our react-native-xcode.sh.

added to fabric tester

expo-bot · 2023-03-03T23:13:30Z

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

packages/@expo/config-plugins/CHANGELOG.md

Generated by ExpoBot 🤖 against c6d50ba

expo-bot · 2023-03-03T23:15:06Z

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing links in changelog entries

I've added some suggestions below, you can just apply and commit them 😉

Generated by ExpoBot 🤖 against c85b1b3

packages/@expo/config-plugins/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

thespacemanatee · 2023-03-12T06:49:42Z

Hey @EvanBacon, I'm getting Unknown or unexpected option: --platform when using @expo/cli instead of rn-cli and it looks like it's caused by this PR, should I create an issue?

) # Why - Related #21396 - Use `npx expo start --dev-client` instead of `npx react-native start` when building a project from Xcode. This ensures we use the correct version of Metro regardless of where the project is started. - It's unclear if building from Android Studio is supposed to trigger the bundler in development but I couldn't get it to do so, so this PR is iOS-only.  # How - Copy over a bunch of the default scripts from `react-native/scripts` into the same locations in `expo/scripts` to make it easy to maintain this change and simple to migrate. I decided to omit the following as it appeared to be unused (sets RCT_METRO_PORT): ``` source "$THIS_DIR/.packager.env" ``` I also dropped: - Support for `$RCT_PACKAGER_LOGS_DIR`. - The `Process terminated. Press <enter> to close the window` log that is presented after closing the dev server. - Support for a custom React Native CLI config (this is not supported in Expo CLI).  # Test Plan - TBD - Building for development from Xcode causes a terminal window running `npx expo start` will open instead of the community version.  # Checklist  - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Kudo Chien <kudo@expo.dev>

# Why - Possible since #21396 - If the `metro.config.js` is missing, then the default, `@expo/metro-config`, will be used. - Drop `metro.config.js` copy step in `expo prebuild` in favor of `expo export:embed` and the new Xcode start script using Expo CLI--this only works when using Expo CLI for all bundling (SDK +49). - Maybe we could add a metro linting step to `npx expo-doctor` in the future. # Test Plan - tbd # Checklist  - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Aman Mittal <amandeepmittal@live.com>

EvanBacon and others added 8 commits October 24, 2022 15:13

feat(cli): add proxy bundle command

03497d2

Merge branch 'main' into @evanbacon/cli/bundle-proxy-command

6b501af

unify metro config loading

1db192b

ensure no other loading is used

b78e7ac

import direct

0e00f76

working

87df8ed

update template to use bundle:proxy on iOS

0335558

update template to use bundle:proxy on Android

847d575

expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 25, 2023

expo-bot reviewed Feb 25, 2023

View reviewed changes

packages/expo/CHANGELOG.md Outdated Show resolved Hide resolved

EvanBacon mentioned this pull request Feb 25, 2023

feat(expo)!: use Expo CLI when building for development in Xcode #21397

Merged

3 tasks

EvanBacon requested a review from Kudo February 25, 2023 01:34

Update packages/expo/CHANGELOG.md

ef34469

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

This comment was marked as duplicate.

Sign in to view

bundle:proxy -> export:embed

a56665e

This comment was marked as duplicate.

Sign in to view

Add setup docs

a111301

This comment was marked as duplicate.

Sign in to view

EvanBacon marked this pull request as ready for review February 28, 2023 21:51

EvanBacon requested review from Simek, amandeepmittal, kbrandwijk, ide, tsapeta, brentvatne and byCedric as code owners February 28, 2023 21:51

use export:embed in bare-expo

c91a452

This comment was marked as duplicate.

Sign in to view

EvanBacon removed the request for review from Simek February 28, 2023 22:40

Update CHANGELOG.md

f1f6e11

expo-bot reviewed Mar 1, 2023

View reviewed changes

packages/@expo/cli/CHANGELOG.md Outdated Show resolved Hide resolved

Update packages/@expo/cli/CHANGELOG.md

126f8a0

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

ide approved these changes Mar 1, 2023

View reviewed changes

Kudo reviewed Mar 2, 2023

View reviewed changes

EvanBacon added 3 commits March 2, 2023 11:23

fix command typo

f033069

added to fabric tester

Add new --asset-catalog-dest

e8b8c7b

add double quotes around PROJECT_ROOT

d3cfc7a

Kudo approved these changes Mar 3, 2023

View reviewed changes

EvanBacon added 4 commits March 3, 2023 16:23

Update prebuild-test.ts

26b172b

update build files

a507c74

Merge branch 'main' into @evanbacon/cli/bundle-proxy-command

1708500

fix tests

c6d50ba

Update CHANGELOG.md

c85b1b3

expo-bot reviewed Mar 3, 2023

View reviewed changes

packages/@expo/config-plugins/CHANGELOG.md Outdated Show resolved Hide resolved

EvanBacon and others added 3 commits March 3, 2023 17:24

Update packages/@expo/config-plugins/CHANGELOG.md

1e808d4

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

Merge branch 'main' into @evanbacon/cli/bundle-proxy-command

a027ccf

Update instantiateMetro.ts

0e38d3c

EvanBacon merged commit b6b91c5 into main Mar 6, 2023

EvanBacon deleted the @evanbacon/cli/bundle-proxy-command branch March 6, 2023 18:28

EvanBacon mentioned this pull request Apr 8, 2023

Drop metro.config.js copy step in expo prebuild #22045

Merged

3 tasks

EvanBacon mentioned this pull request Aug 2, 2023

migrate parts of repo to expo cli #23806

Merged

Kudo mentioned this pull request Aug 22, 2023

Sourcemaps not working (Metro bundler) getsentry/sentry-react-native#3244

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli)!: use Expo CLI to bundle production apps #21396

feat(cli)!: use Expo CLI to bundle production apps #21396

EvanBacon commented Feb 25, 2023 •

edited

expo-bot commented Feb 25, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

expo-bot commented Mar 1, 2023

Kudo left a comment

Kudo commented Mar 2, 2023

expo-bot commented Mar 3, 2023

expo-bot commented Mar 3, 2023

thespacemanatee commented Mar 12, 2023 •

edited

feat(cli)!: use Expo CLI to bundle production apps #21396

feat(cli)!: use Expo CLI to bundle production apps #21396

Conversation

EvanBacon commented Feb 25, 2023 • edited

Why

How

Test Plan

Checklist

expo-bot commented Feb 25, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

expo-bot commented Mar 1, 2023

Kudo left a comment

Choose a reason for hiding this comment

Kudo commented Mar 2, 2023

expo-bot commented Mar 3, 2023

expo-bot commented Mar 3, 2023

thespacemanatee commented Mar 12, 2023 • edited

EvanBacon commented Feb 25, 2023 •

edited

thespacemanatee commented Mar 12, 2023 •

edited