[core][ios] Fix jsc import when using use_frameworks #21479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
reviewed
Mar 2, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Kudo
approved these changes
Mar 2, 2023
lukmccall
approved these changes
Mar 2, 2023
Kudo
pushed a commit
that referenced
this pull request
Mar 3, 2023
# Why iOS projects using `use_frameworks!` along with JSC are broken on SDK 48 Closes #21461 # How This PR adds an additional import check for `<React_jsc/JSCRuntime.h>` inside `EXJavaScriptRuntime.mm` as when in framework mode dashes are replaced with underscores. # Test Plan Update bare-expo `Podfile.properties.json` to ``` { "expo.jsEngine": "jsc", "ios.useFrameworks": "static" } ``` and build the app # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> (cherry picked from commit 32c7a27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
iOS projects using
use_frameworks!along with JSC are broken on SDK 48Closes #21461
How
This PR adds an additional import check for
<React_jsc/JSCRuntime.h>insideEXJavaScriptRuntime.mmas when in framework mode dashes are replaced with underscores.Test Plan
Update bare-expo
Podfile.properties.jsontoand build the app
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).