[cli] Add graphql-codegen #21980
Merged
[cli] Add graphql-codegen #21980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
approved these changes
Apr 4, 2023
wschurman
force-pushed
the
@wschurman/graphql-codegen
branch
from
d0400f6
to
f05ff8b
Compare
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Apr 5, 2023
# Why When we added the graphql-codegen to the cli on #21980, we forgot to also update `.eslintignore`, causing the `SDK / check-packages` action to fail # How Update `.eslintignore` to point to the new generated file path # Test Plan `SDK / check-packages` should succeed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
EvanBacon
pushed a commit
that referenced
this pull request
Apr 6, 2023
EvanBacon
pushed a commit
that referenced
this pull request
Apr 6, 2023
# Why When we added the graphql-codegen to the cli on #21980, we forgot to also update `.eslintignore`, causing the `SDK / check-packages` action to fail # How Update `.eslintignore` to point to the new generated file path # Test Plan `SDK / check-packages` should succeed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I started adding a new field to the CurrentUserQuery and noticed that the comment indicating that this was generated was a lie (it was just copied in, confirmed with original author who shall not be named due to their constitutional protections for the accused). So this PR makes it truthful by adding the codegen.
How
Copy the way it's set up in eas-cli.
Test Plan
yarn generate-graphql-codeand inspect the results.Checklist
expo prebuild& EAS Build (eg: updated a module plugin).