[ios] Fix weak objects implementation on Hermes #21986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
reviewed
Apr 6, 2023
Comment on lines
16
to
19
| Shared pointer to the `WeakRef` JS object. Available only on JSC engine. | ||
| */ | ||
| std::shared_ptr<jsi::Object> _jsObject; | ||
| std::shared_ptr<jsi::Object> _weakRef; | ||
|
|
||
| /** | ||
| A weak reference to a JS object. Available only on Hermes engine. | ||
| */ | ||
| std::shared_ptr<jsi::WeakObject> _weakObject; |
There was a problem hiding this comment.
do you want to have #if __has_include(<reacthermes/HermesExecutorFactory.h>) also to these member variables? and you can also use the same _weakRef name
e.g.
#if __has_include(<reacthermes/HermesExecutorFactory.h>)
/**
A weak reference to a JS object. Available only on Hermes engine.
*/
std::shared_ptr<jsi::WeakObject> _weakRef;
#else
/**
Shared pointer to the `WeakRef` JS object. Available only on JSC engine.
*/
std::shared_ptr<jsi::Object> _weakRef;
#endifThere was a problem hiding this comment.
Good idea! I applied your suggestion, but used _weakObject instead of _weakRef because the latter has more sense when it refers only to WeakRef instance.
tsapeta
force-pushed
the
@tsapeta/ios/weak-objects-hermes
branch
from
712249f
to
6b6a7b2
Compare
Kudo
approved these changes
Apr 7, 2023
tsapeta
force-pushed
the
@tsapeta/ios/weak-objects-hermes
branch
from
6b6a7b2
to
3b9dad7
Compare
expo-bot
added
bot: passed checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
JavaScriptWeakObjecton iOS usedWeakRefif it was supported by the engine (only JSC as of iOS 14.5), otherwise it worked like strong-referenced object and caused memory leaks. As of React Native 0.71, we can leveragejsi::WeakObjectwhich is implemented on Hermes.How
Added separate implementation for weak objects on Hermes runtimes
Test Plan
Added simple native class and created a milion of instances (on the JS side) and confirmed they are getting deallocated over time