Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metro-config): add sass #22031

Merged
merged 2 commits into from
Apr 7, 2023
Merged

feat(metro-config): add sass #22031

merged 2 commits into from
Apr 7, 2023

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Apr 6, 2023 •
edited

Why

Standard feature for modern web support.

How

  • When a project has CSS setup and sass installed, they can use sass syntax in scss/sass files.
  • Sass is compiled to CSS before it's passed to the standard CSS handling. This means that css modules also support sass.
  • Just like standard CSS support, importing external files is not currently supported.

Test Plan

  • tbd

Checklist

@EvanBacon EvanBacon changed the title feat(metro-config): add sass support to metro web feat(metro-config): add sass Apr 6, 2023
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 6, 2023
EvanBacon added a commit that referenced this pull request Apr 6, 2023
@EvanBacon
move sass to #22031
92f0867
@EvanBacon @expo-bot
Update packages/@expo/metro-config/CHANGELOG.md
311f4e9 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 6, 2023
@EvanBacon EvanBacon merged commit 7cebda5 into main Apr 7, 2023
13 of 15 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/metro-config/sass branch April 7, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Awaiting requested review from Simek Simek is a code owner

@amandeepmittal amandeepmittal Awaiting requested review from amandeepmittal amandeepmittal is a code owner

@kbrandwijk kbrandwijk Awaiting requested review from kbrandwijk

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EvanBacon @expo-bot