Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metro-config): escape backticks #22040

Merged
merged 2 commits into from
Apr 8, 2023
Merged

Conversation

EvanBacon
Copy link
Contributor

Why

backticks need to be escaped for CSS script injection to work.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 8, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 8, 2023
@EvanBacon EvanBacon merged commit 7931032 into main Apr 8, 2023
5 of 6 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/metro/escape-css branch April 8, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants