Allow environment variables to be mutable in development. #22072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
approved these changes
Apr 10, 2023
EvanBacon
requested review from
Simek,
amandeepmittal and
kbrandwijk
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
|
@EvanBacon It look like this PR broke the docs build: |
Simek
reviewed
Apr 11, 2023
| @@ -371,6 +371,7 @@ From here, you can choose to generate basic project files like: | |||
| | `EXPO_USE_PATH_ALIASES` | **boolean** | <StatusTag status="experimental" note="SDK 49+" /><br/>Allow Metro to use the `compilerOptions.paths` and `compilerOptions.baseUrl` features from **tsconfig.json** or **jsconfig.json**) to enable import aliases and absolute imports. | | |||
| | `EXPO_USE_CUSTOM_INSPECTOR_PROXY` | **boolean** | <StatusTag status="experimental" note="SDK 49+" /><br/>Use a customized inspector proxy with improved support for the Chrome DevTools protocol.<br/>This includes support for the network inspector. | | |||
| | `EXPO_USE_TYPED_ROUTES` | **boolean** | <StatusTag status="experimental" note="SDK 49+" /><br/>Generate TypeScript types for Expo Router.<br/>This includes support for the network inspector. | | |||
| | `EXPO_NO_CLIENT_ENV_VARS` | **boolean** | <StatusTag note="SDK 49+" /><br/>Prevent inlining `EXPO_PUBLIC_` environment variables in client bundles. | | |||
There was a problem hiding this comment.
status is a required prop.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
React Native is extraneously defining the environment variables, so we need to allow them to mutate. This is a bit problematic since they can only be mutated in development and not in production, meaning there's a fork of behavior.