Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to react-native 0.71.7 #22253

Merged
merged 12 commits into from
Apr 26, 2023
Merged

upgrade to react-native 0.71.7 #22253

merged 12 commits into from
Apr 26, 2023

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Apr 25, 2023 •
edited

Why

upgrade react-native 0.71.7 for ios hermes performance regression and samsung textinput issues: https://github.com/facebook/react-native/releases/tag/v0.71.7

How

  • update react-native@0.71.7 in package.json
  • update our react-native fork to 0.71.7
  • re-version sdk 48 code because there are ios hermes changes and android java code changes
  • [skia] fix build error on xcode 14.3
  • [dev-menu][dev-launcher] update bundles

Test Plan

  • ci passed
    • cli and versioned ios client eas build are expected to fail on sdk-48.
  • android/ios versioned expo go + ncl

Checklist

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against 3ce3e85

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 25, 2023
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against d7fad14

@Kudo Kudo marked this pull request as ready for review April 25, 2023 11:03
brentvatne
brentvatne approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Kudo Kudo merged commit b0d7000 into sdk-48 Apr 26, 2023
1 check failed
@Kudo Kudo deleted the @kudo/rn0717 branch April 26, 2023 01:11
@Kudo Kudo added the published Changes from the PR have been published to npm label Apr 26, 2023
Kudo added a commit that referenced this pull request Apr 26, 2023
@Kudo
Upgrade react-native 0.71.7 (#22253)
ab35a1c 
upgrade react-native 0.71.7 for ios hermes performance regression and samsung textinput issues: https://github.com/facebook/react-native/releases/tag/v0.71.7

- update `react-native@0.71.7` in package.json
- update our react-native fork to 0.71.7
- re-version sdk 48 code because there are ios hermes changes and android java code changes
- [skia] fix build error on xcode 14.3
- [dev-menu][dev-launcher] update bundles

- ci passed
  - cli and versioned ios client eas build are expected to fail on sdk-48.
- android/ios versioned expo go + ncl

(cherry picked from commit b0d7000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@tsapeta tsapeta Awaiting requested review from tsapeta tsapeta is a code owner

Assignees
No one assigned
Labels
bot: suggestions ExpoBot has some suggestions published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kudo @expo-bot @brentvatne