fix(cli): output verbose install logs when prebuilding on CI #22361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other places that could also benefit from more CI logging: |
expo-bot
added
bot: passed checks
brentvatne
approved these changes
May 3, 2023
byCedric
force-pushed
the
@bycedric/cli/prebuild-ci-logging
branch
from
3b7936b
to
e05b410
Compare
byCedric
added a commit
that referenced
this pull request
May 30, 2023
This should help figuring out why a certain build failed in CI. - Added `env.CI` check besides the existing `env.EXPO_DEBUG` check - `CI=true npx expo prebuild` should output verbose install logs <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This should help figuring out why a certain build failed in CI.
How
env.CIcheck besides the existingenv.EXPO_DEBUGcheckTest Plan
CI=true npx expo prebuildshould output verbose install logsChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).