feat: add SearchParams types to Expo Router #22380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
useLocalSearchParams
in currently typed. We can not generate a helper type to convert a route to the SearchParams objectsThese types are strongly connected to the generated routes and will break if a route ever changes (e.g the variable is renamed).
Relative routes are ignores and are currently considered out of scope.
One annoying downside is that the autocomplete doesn't work. This due to typescript simply not supporting it microsoft/TypeScript#34771