[modules][system-ui] Persist user selected background color #22773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
reviewed
Jun 6, 2023
EvanBacon
approved these changes
Jun 6, 2023
expo-bot
added
bot: passed checks
tsapeta
reviewed
Jun 7, 2023
packages/expo-system-ui/ios/ExpoSystemUI/ExpoSystemUIModule.swift
Outdated
Show resolved
Hide resolved
|
waiting on review from @tsapeta |
tsapeta
approved these changes
Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 23, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
3 tasks
Kudo
added a commit
that referenced
this pull request
Dec 15, 2023
# Why expo-system-ui config plugin will setup `RCTRootViewBackgroundColor` from app.json's `ios.backgroundColor` to info.plist. from #22773, we break this and expo-system-ui will always use system default color as the background color: https://github.com/expo/expo/blob/e281adb30e978c382220686ffb0cb1b665f8d3c5/packages/expo-system-ui/ios/ExpoSystemUI/ExpoSystemUIModule.swift#L44-L60 # How if the color is not persisted yet, we should respect the color from `RCTRootViewBackgroundColor`
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
) # Why expo-system-ui config plugin will setup `RCTRootViewBackgroundColor` from app.json's `ios.backgroundColor` to info.plist. from expo#22773, we break this and expo-system-ui will always use system default color as the background color: https://github.com/expo/expo/blob/e281adb30e978c382220686ffb0cb1b665f8d3c5/packages/expo-system-ui/ios/ExpoSystemUI/ExpoSystemUIModule.swift#L44-L60 # How if the color is not persisted yet, we should respect the color from `RCTRootViewBackgroundColor`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-8736
How
Setting the background color is now persisted and restored when the app is launched (on iOS). On Android, a new function had to be added to restore the color on app start. If no color is provided the default will be black when in dark mode or white otherwise.
Test Plan
Tested on physical devices and emulators with bare expo.