Fix port in use message for unidentified process #22814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
approved these changes
Jul 14, 2023
byCedric
pushed a commit
that referenced
this pull request
Jul 18, 2023
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> The current message when the port is in use is confusing when the running process cannot be identified; it just says "Port <#> is." This happens for example on Windows/PowerShell where the running process detector does not work. Closes #22774. # How <!-- How did you build this feature or fix this bug and why? --> Added "being used by another process" to the message in the `else` block. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Had trouble writing a unit test due to the dynamic imports in the function, which don't seem to play well with Jest. However, I was able to test it locally:  # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
EvanBacon
pushed a commit
that referenced
this pull request
Jul 19, 2023
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> The current message when the port is in use is confusing when the running process cannot be identified; it just says "Port <#> is." This happens for example on Windows/PowerShell where the running process detector does not work. Closes #22774. # How <!-- How did you build this feature or fix this bug and why? --> Added "being used by another process" to the message in the `else` block. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Had trouble writing a unit test due to the dynamic imports in the function, which don't seem to play well with Jest. However, I was able to test it locally:  # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current message when the port is in use is confusing when the running process cannot be identified; it just says "Port <#> is." This happens for example on Windows/PowerShell where the running process detector does not work. Closes #22774.
How
Added "being used by another process" to the message in the
elseblock.Test Plan
Had trouble writing a unit test due to the dynamic imports in the function, which don't seem to play well with Jest. However, I was able to test it locally:
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).