Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): noop source maps for context modules #22874

Merged
merged 4 commits into from Jun 13, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

@EvanBacon EvanBacon requested a review from byCedric as a code owner June 13, 2023 21:01
@linear
Copy link

linear bot commented Jun 13, 2023

ENG-8900 Fix metro error that shows when chrome requests source maps for a context module

This shows when you modify the require context in web. Perhaps we can fix by prepending a middleware in Expo CLI to intercept the request and noop.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 13, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon merged commit 2e1e108 into main Jun 13, 2023
3 of 5 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/noop-source-maps-for-context-modules branch June 13, 2023 21:46
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants