feat(cli): auto enable --dev-client in npx expo start
#22926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
Simek,
amandeepmittal,
kbrandwijk and
byCedric
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
brentvatne
reviewed
Jun 15, 2023
| | <kbd>M</kbd> | Open the dev menu on any connected native device (web not supported). | | ||
| | <kbd>Shift</kbd> + <kbd>M</kbd> | Choose more commands to trigger on connected devices.<br/>This includes toggling the performance monitor, opening the element inspector, reloading the device, and opening the dev menu. | | ||
| | <kbd>J</kbd> | Open Chrome Dev Tools for any connected device that is using Hermes as the JavaScript engine. [Learn more](/guides/using-hermes#javascript-inspector-for-hermes). | | ||
| | <kbd>O</kbd> | Open project code in your editor. This can be configured with the `EXPO_EDITOR` and `EDITOR` [environment variables](#environment-variables). | | ||
| | <kbd>E</kbd> | Show the development server URL as a QR code in the terminal. | | ||
| | <kbd>?</kbd> | Show all Terminal UI commands. | | ||
|
|
||
| ### Launch target | ||
|
|
||
| The `npx expo start` command will automatically launch the app in Expo Go unless `expo-dev-client` in installed in the project, in which case it will open in the custom app. You can force the launch target by passing the `--dev-client` and `--go` flags. For example, running `npx expo start --go` will always launch the app in Expo Go, and `npx expo start --dev-client` will always attempt to launch the app in a development build. |
There was a problem hiding this comment.
the case this doesn't handle is a native app without expo-dev-client. npx expo start in a react-native app w/ ios and android directories probably shouldn't default to expo go
There was a problem hiding this comment.
it's fine for now as this is the existing behavior and we don't break anything by merging new functionality for a different case. If users are doing development in an unintended way, then they may need to pass an additional flag (already the default), or switch the mode by pressing s.
This was referenced Jun 22, 2023
This was referenced Jun 23, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
--dev-clientwhenexpo-dev-clientis in the projectpackage.json. Users can swap to Expo Go withsor pass--goto ensure Expo Go is the default target.Test Plan