refactor(cli): enable inspector proxy with network support by default #22936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
requested review from
Simek,
amandeepmittal and
kbrandwijk
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
byCedric
commented
Jun 16, 2023
| @@ -326,6 +326,7 @@ For example, you are testing a new version of `react-native-reanimated` to verif | |||
| You can exclude specific packages from the version checks while still allowing the `install` command to install, check, and fix any other dependencies. This configuration extends to the checking done by `npx expo-doctor`. | |||
|
|
|||
| To exclude packages from version checking, set the `expo.install` config object in your project's **package.json**: | |||
|
|
|||
There was a problem hiding this comment.
I ran "format" on this page, which added this, but I can remove it 🤷 (but it seems like a good addition, separating code blocks with text a bit nicer)
byCedric
commented
Jun 16, 2023
Kudo
approved these changes
Jun 16, 2023
byCedric
commented
Jun 16, 2023
| {formatName(status)} | ||
| {note && `: ${note}`} | ||
| </span> | ||
| <span css={labelStyle}>{status ? formatName(status) + (note ? `: ${note}` : '') : note}</span> |
There was a problem hiding this comment.
This was required to use the <StatusTag /> with just notes (as in, for just adding "SDK XX+")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Flipping this switch to be opt-out for SDK 49.
How
EXPO_USE_CUSTOM_INSPECTOR_PROXY=truetoEXPO_NO_INSPECTOR_PROXY=falseTest Plan
$ EXPO_DEBUG=true expo start-> should mentionExpo inspector proxy enabledin the debug logs.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).