Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Step: fix possible overflow on mobile in certain cases #22973

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jun 19, 2023

Why

Fixes ENG-9002

How

Make sure that Step component do not exceed the viewport on mobile, when it contains a flex base component in its content.

Test Plan

The changes have been tested by running docs app locally.

Preview

Screenshot 2023-06-19 at 21 17 04

@linear
Copy link

linear bot commented Jun 19, 2023

ENG-9002 Terminal snippets in Step component cause docs text to overflow on phones

See https://docs.expo.dev/build/internal-distribution/#configure-app-signing. Use Chrome dev tools to simulate a phone (I tried iPhone 12 Pro). The text gets cut off: https://twitter.com/charlienoller_/status/1670848489171845125

The cause looks to be the terminal UI snippet that's a bit later in the section. You can verify this by changing white-space: pre to white-space: normal on the elements and the text no longer overflows. I don't think this is the fix — just confirms the terminal snippet is the cause of the overflow.

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants