Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove invalid "none" platform #23080

Merged
merged 2 commits into from Jun 24, 2023

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Jun 24, 2023

Why

  • fix regression introduced in [expo-cli] Add platform when running --dev-client #19319
    • none is passed to the bundler and implies the existence of .none.js files, and Platform.select({ none: '...' }) which isn't valid.
    • The default in classic and all other implementations of the metro dev server has been to fallback on ios.
    • The most correct variation would be to fallback on web as the web is a non-standard React Native client which doesn't implement the expo manifest format. However, (metro) web isn't enabled in every project, and if it were then the JSON manifest would be skipped in favor of the HTML file.
  • remove unneeded logs about offline and anonymous.
  • add force-manifest-type options to help prompt.

How

Test Plan

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 24, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon marked this pull request as ready for review June 24, 2023 05:45
@EvanBacon EvanBacon requested a review from byCedric as a code owner June 24, 2023 05:45
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 24, 2023
@EvanBacon EvanBacon merged commit d7ad395 into main Jun 24, 2023
5 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/remove-invalid-none-platform branch June 24, 2023 23:08
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants