refactor(cli): avoid changing required dependency versions when prebuilding #23146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of overwriting, the user is prompted with a warning that they arent using the recommended versions. This can be resolved with `expo install --fix` before prebuilding.
byCedric
changed the title
byCedric
force-pushed
the
@bycedric/cli/only-add-required-dependencies
branch
from
fe62ad0
to
cafba40
Compare
byCedric
changed the title
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
brentvatne
approved these changes
Jun 27, 2023
byCedric
added a commit
that referenced
this pull request
Jun 28, 2023
…ilding (#23146) # Why In the past, we've had issues with bugfixes and minor bumps causing issues in user projects, without user knowledge of these bumps. # How Instead of overwriting, the user is prompted with a warning that they arent using the recommended versions. This can be resolved with `expo install --fix` before prebuilding. # Test Plan - `$ yarn create expo ./test` - Downgrade (patch or minor) any of these packages: - `expo`, `expo-splash-screen`, `react`, or `react-native` - `$ yarn expo prebuild` - This command should warn you that you are not using the recommended versions. It should NOT change these versions. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
This was referenced Jun 28, 2023
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In the past, we've had issues with bugfixes and minor bumps causing issues in user projects, without user knowledge of these bumps.
How
Instead of overwriting, the user is prompted with a warning that they arent using the recommended versions. This can be resolved with
expo install --fixbefore prebuilding.Test Plan
$ yarn create expo ./testexpo,expo-splash-screen,react, orreact-native$ yarn expo prebuildChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).