chore: update react-native to 0.72.1 #23262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
the
bot: needs changes
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Forbidden file size or format
Generated by ExpoBot 🤖 against da7c5b0 |
Kudo
requested review from
tsapeta,
ide,
brentvatne,
lukmccall and
douglowder
as code owners
tsapeta
reviewed
Jul 3, 2023
Comment on lines
+112
to
+114
| imageRequest.cancel(); | ||
| imageRequest.cancel(); | ||
| imageRequest.cancel(); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Why does this PR change these assets? 🤔
There was a problem hiding this comment.
since fd7025d, we haven't update dev-menu bundles.
tsapeta
approved these changes
Jul 3, 2023
Kudo
added a commit
that referenced
this pull request
Jul 3, 2023
update react-native 0.72.1 for sdk 49 - bump react-native to 0.72.1 - re-version android/ios sdk 49 code - [react-native-lab] cherry-pick necessary commits between 0.72.0..0.72.1 - ci passed - bare-expo - versioned expo go (cherry picked from commit 895fafd)
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
update react-native 0.72.1 for sdk 49
How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).