[cli] Use node server default port selection for SSO login server #23505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-8950 [eas cli, expo cli] Start server listen on port 0, and get port after
See if we can let the OS find a free port instead of using freePort package - start server listening on port 0 and then get the port from the addressInfo once the server has started |
wschurman
force-pushed
the
@wschurman/port-selection
branch
from
b8b41f6
to
d8ce61a
Compare
expo-bot
added
bot: passed checks
EvanBacon
reviewed
Jul 13, 2023
EvanBacon
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As suggested in expo/eas-cli#1875 (comment), we can just use the default port selection mechanism for starting a listener server for the SSO auth redirect.
Closes ENG-8950.
How
Change code to use default port selection.
Test Plan
(see it logs in)
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).