fix(metro-config): keep existing URL parts when rewriting virtual entrypoint urls #23546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
approved these changes
Jul 15, 2023
byCedric
added a commit
that referenced
this pull request
Jul 16, 2023
…rypoint urls (#23546) Metro uses the `server.rewriteRequestUrl` during hot module reloads, and uses the output as both `sourceMappingUrl` and `sourceUrl`. These two properties are important for debugging, as it essentially tells the debugger all original information it needs about the transpiled file. On initial load, this works fine, but after changing a file, Metro sends an incorrect URL to the debugger. This causes issues when updating the original sources within the debuggers.  - Added test case to keep existing `protocol`, `host`, and `port` to the rewritten URL (if defined) - Only replaced the `pathname` when URL is a full URL. See added test <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
byCedric
added a commit
that referenced
this pull request
Jul 18, 2023
…rypoint urls (#23546) # Why Metro uses the `server.rewriteRequestUrl` during hot module reloads, and uses the output as both `sourceMappingUrl` and `sourceUrl`. These two properties are important for debugging, as it essentially tells the debugger all original information it needs about the transpiled file. On initial load, this works fine, but after changing a file, Metro sends an incorrect URL to the debugger. This causes issues when updating the original sources within the debuggers.  # How - Added test case to keep existing `protocol`, `host`, and `port` to the rewritten URL (if defined) - Only replaced the `pathname` when URL is a full URL. # Test Plan See added test # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Metro uses the
server.rewriteRequestUrlduring hot module reloads, and uses the output as bothsourceMappingUrlandsourceUrl. These two properties are important for debugging, as it essentially tells the debugger all original information it needs about the transpiled file.On initial load, this works fine, but after changing a file, Metro sends an incorrect URL to the debugger. This causes issues when updating the original sources within the debuggers.
How
protocol,host, andportto the rewritten URL (if defined)pathnamewhen URL is a full URL.Test Plan
See added test
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).