feat(cli): add expo typescript command
#23642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
force-pushed
the
marklawlor/cli/typed-routes/generation
branch
from
7b18f48
to
1db875f
Compare
marklawlor
changed the title
expo typescript command
This command will automaticaly setup your project with Typescript and generate any Expo related types.
marklawlor
force-pushed
the
marklawlor/cli/typed-routes/generation
branch
from
2014a6d
to
35eef1c
Compare
marklawlor
commented
Jul 20, 2023
EvanBacon
reviewed
Jul 20, 2023
EvanBacon
reviewed
Jul 20, 2023
EvanBacon
reviewed
Jul 20, 2023
EvanBacon
reviewed
Jul 27, 2023
EvanBacon
reviewed
Jul 27, 2023
EvanBacon
reviewed
Jul 27, 2023
EvanBacon
reviewed
Aug 14, 2023
| @@ -85,6 +85,13 @@ export const TEMPLATES: { | |||
| destination: ({ webStaticPath }) => webStaticPath + '/index.html', | |||
| dependencies: [], | |||
| }, | |||
| { | |||
| // `tsconfig.json` is special cased and don't not follow the template | |||
There was a problem hiding this comment.
Suggested change
| // `tsconfig.json` is special cased and don't not follow the template | |
| // `tsconfig.json` is special cased and do not follow the template |
EvanBacon
reviewed
Aug 14, 2023
| // Ensure the process doesn't fail if the TypeScript check fails. | ||
| // This could happen during the install. | ||
| Log.log(); | ||
| Log.exception(error); |
There was a problem hiding this comment.
Maybe we want to throw here?
EvanBacon
approved these changes
Aug 15, 2023
EvanBacon
pushed a commit
that referenced
this pull request
Aug 23, 2023
# Why The command serves two purposes - Allow users to manually start the Expo Typescript bootstrap process - Generate Expo Router types within CI environments. Unlike the automatic Typescript detection, this command will bypass prompts and simply enable Typescript support. # How Reuses `TypeScriptProjectPrerequisite` and the Typescript services from `MetroBundlerDevServer`. This PR also modifies the `MetroBundlerDevServer.startTypeScriptServices()` to run without a started server (so file watching will be disabled) # Test Plan # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
brentvatne
pushed a commit
that referenced
this pull request
Oct 19, 2023
# Why The command serves two purposes - Allow users to manually start the Expo Typescript bootstrap process - Generate Expo Router types within CI environments. Unlike the automatic Typescript detection, this command will bypass prompts and simply enable Typescript support. # How Reuses `TypeScriptProjectPrerequisite` and the Typescript services from `MetroBundlerDevServer`. This PR also modifies the `MetroBundlerDevServer.startTypeScriptServices()` to run without a started server (so file watching will be disabled) # Test Plan # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The command serves two purposes
Unlike the automatic Typescript detection, this command will bypass prompts and simply enable Typescript support.
How
Reuses
TypeScriptProjectPrerequisiteand the Typescript services fromMetroBundlerDevServer.This PR also modifies the
MetroBundlerDevServer.startTypeScriptServices()to run without a started server (so file watching will be disabled)Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).