fix: Expo Router type generation for whitespace filenames #23662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
EvanBacon
approved these changes
Jul 21, 2023
EvanBacon
added a commit
that referenced
this pull request
Jul 21, 2023
Expo Router type generation normalised whitespace when we should preserve it. This keeps the types inline with edge case usage. `/(my group, my other group )/my page.tsx` is a valid filename. It should be typed as ``` /(my group)/my page /(my other group)/my page /my page ``` Removed the URL normalisation and changed the group regex's to preserve white space. Group names are now trimmed Updated unit tests <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: evanbacon <bacon@expo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expo Router type generation normalised whitespace when we should preserve it. This keeps the types inline with edge case usage.
/(my group, my other group )/my page.tsxis a valid filename.It should be typed as
How
Removed the URL normalisation and changed the group regex's to preserve white space. Group names are now trimmed
Test Plan
Updated unit tests
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).