Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure folder exists #23664

Merged
merged 2 commits into from Jul 21, 2023

Conversation

marklawlor
Copy link
Contributor

Why

If the user deletes the .expo or .expo/types folder while running Expo Router type generation, the CLI process would crash. This ensures the folder always exists before writing to it.

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jul 21, 2023
@EvanBacon EvanBacon merged commit fc97985 into main Jul 21, 2023
5 checks passed
@EvanBacon EvanBacon deleted the marklawlor/cli/typed-routes/regenerate-types-folder branch July 21, 2023 18:00
EvanBacon pushed a commit that referenced this pull request Jul 21, 2023
# Why

If the user deletes the `.expo` or `.expo/types` folder while running
Expo Router type generation, the CLI process would crash. This ensures
the folder always exists before writing to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants