migrate expo-router to expo/expo #23725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
the
bot: needs changes
Merged
EvanBacon
added a commit
that referenced
this pull request
Jul 29, 2023
# Why - `expo-stories` is unmaintained and unused. - The dependency on react-navigation is blocking the expo-router migration #23725 because there are no maintainers it's unclear how to safely upgrade react-navigation in stories.
expo-bot
added
bot: suggestions
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
rodriigovieira
pushed a commit
to Qeepsake/expo-in-app-purchases
that referenced
this pull request
Oct 24, 2023
# Why - `expo-stories` is unmaintained and unused. - The dependency on react-navigation is blocking the expo-router migration expo/expo#23725 because there are no maintainers it's unclear how to safely upgrade react-navigation in stories.
nahn20
pushed a commit
to nahn20/expo-image-picker
that referenced
this pull request
Jan 23, 2024
# Why - `expo-stories` is unmaintained and unused. - The dependency on react-navigation is blocking the expo-router migration expo/expo#23725 because there are no maintainers it's unclear how to safely upgrade react-navigation in stories.
nahn20
pushed a commit
to nahn20/expo-media-library
that referenced
this pull request
Mar 4, 2024
# Why - `expo-stories` is unmaintained and unused. - The dependency on react-navigation is blocking the expo-router migration expo/expo#23725 because there are no maintainers it's unclear how to safely upgrade react-navigation in stories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Migrate expo-router to expo/expo from expo/router so we can version it with the Expo SDK. Also required for further integration with Expo CLI, expo-font, expo-image, etc.
How
expo-router, and@expo/metro-runtime.expo-headintoexpo-router.apps/sandboxfor low-stakes testing. Another PR can pull in.Test Plan
apps/sandboxstarts on all platforms and pulls from expo-router in thepackagesdirectory.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).