[expo] Remove the environment validator #23732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/remove-environment-validator
branch
2 times, most recently
from
f5795ab
to
703d02f
Compare
expo-bot
added
bot: passed checks
brentvatne
approved these changes
Aug 2, 2023
tsapeta
force-pushed
the
@tsapeta/remove-environment-validator
branch
from
8b2a16c
to
cd73c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This doesn't seem to be useful since we dropped standalone apps and needs to be removed in order to remove the dependency on
expo-constantsHow
Removed the validator, related functions and tests (including snapshots) that seem to be useless now.
Test Plan