Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always apply custom Metro resolver in Expo CLI. #23784

Merged
merged 2 commits into from Jul 31, 2023
Merged

Always apply custom Metro resolver in Expo CLI. #23784

merged 2 commits into from Jul 31, 2023

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Jul 31, 2023 •
edited

Why

  • mjs resolver must always be applied.
  • There are probably other side effects but everything is getting more test coverage this way.

@EvanBacon EvanBacon requested a review from byCedric as a code owner July 31, 2023 18:13
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 31, 2023
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
8eac270 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 31, 2023
@EvanBacon EvanBacon merged commit 8816be9 into main Jul 31, 2023
5 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/always-apply-custom-resolver branch July 31, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kudo Kudo Kudo approved these changes

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @Kudo @expo-bot