chore: improve expo router testing #23795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
expo-bot
added
bot: suggestions
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: suggestions
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
added a commit
that referenced
this pull request
Aug 9, 2023
EvanBacon
added a commit
that referenced
this pull request
Aug 10, 2023
EvanBacon
commented
Aug 10, 2023
EvanBacon
added a commit
that referenced
this pull request
Aug 23, 2023
- Ensure the various aspects of `npx expo export` continue to work with the latest Expo Router/Metro depdencies. - We had a bundling testing for Expo Router but it wasn't linked to the monorepo so the dependencies weren't in sync. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> - Create a new app in `apps/` which is synchronized with the monorepo. - This app contains multiple expo-router directories and various dynamic settings. - Fold the `expo-router` e2e tests into `@expo/cli`. - Test static rendering, single-page application exporting, and the native url polyfill (api). <!-- How did you build this feature or fix this bug and why? --> - The CLI E2E tests should pass. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
npx expo exportcontinue to work with the latest Expo Router/Metro depdencies.How
apps/which is synchronized with the monorepo.expo-routere2e tests into@expo/cli.Test Plan